Skip to content

fix(nix-mode): drop stdenv.lib, quote urls #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2023
Merged

fix(nix-mode): drop stdenv.lib, quote urls #94

merged 1 commit into from
Feb 19, 2023

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 19, 2023 •
edited
Loading

stdenv.lib has been deprecated as well as unquoted urls

  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.
  • I am blindly checking these off.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

@Mic92
fix: drop deprecated stdenv.lib & quote urls for nix-mode
11ff8c7 
stdenv.lib has been deprecated as well as unquoted urls
@hlissner hlissner added is:update An effort to catch up with changes made elsewhere mode:nix labels Feb 19, 2023
@hlissner hlissner added this to the v2.0 milestone Feb 19, 2023
@hlissner hlissner changed the title nix: drop stdenv.lib, quote urls fix(nix-mode): drop stdenv.lib, quote urls Feb 19, 2023
@hlissner hlissner merged commit 1eff383 into doomemacs:master Feb 19, 2023
@hlissner
Copy link
Member

LGTM. Thanks for your help!

@Mic92 Mic92 deleted the nix-updates branch June 15, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlissner hlissner hlissner approved these changes

Assignees
No one assigned
Labels
is:update An effort to catch up with changes made elsewhere mode:nix
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mic92 @hlissner